-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Use Just instead of Make #323
base: master
Are you sure you want to change the base?
Conversation
export SHARE_DIR := sharedir | ||
export BIN_DIR := base-dir / 'bin' | ||
export LIB_DIR := libdir | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Add a line like cargo-target-dir := env('CARGO_TARGET_DIR', 'target')
here to read the CARGO_TARGET_DIR environment variable.
export BIN_DIR := base-dir / 'bin' | ||
export LIB_DIR := libdir | ||
|
||
bin-src := 'target' / 'release' / name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Change this line to bin-src := cargo-target-dir / 'release' / name
to use the previously read environment variable instead of hardcoding the target directory.
This PR moves the build automation system over to Just instead of Make.
Todo (but I may not have the time to do them):